![]() |
|
|||||||
| Notices |
| Graphic Design & Web Design Critique Get Critique from other designers on your graphic & web designs |
![]() |
|
|
LinkBack | Thread Tools | Display Modes |
|
||||
|
What kind of errors does he have, Tommy? How can he fix them? Any suggestions or advice?
__________________
Looking for more specifics on improving your design skills? Visit my blog at CreativeCurio.com |
|
|
|
||||
|
if you click the link I provided, it will tell you, but.. here's the skinny..
![]() Pretty basic fixes.. OPACITY isn't valid yet. Hopefully it will be supported in CSS 3.0
__________________
Tommy Logic ™ Web Design :: Valid XHTML & CSS :: SEO :: CMS :: eCommerce Web Design Tutorials :: Computer Tutorials Last edited by tommylogic; 14-08-2007 at 07:56 PM. |
|
|||
|
A lot has been said about the design already so I won't repeat the words of other but there are serious issues with your code. You've made the big step of using CSS to create your site rather than tables which is great but there are still a few issues that you'll want to address now.
I think you need to take a step back and look at how you've developed your iste (code-wise). I'll use the home page as an example. I would probably use 4 or perhaps 5 divs depending on whether to not there would be a footer. You seem to have used quite a few. It's a big task at the outset but plan it out, the structure of the site (header, nav, left content, right content, etc.) should be the structure of your html. Try and keep your code down to a minimum. Bloated code is bad for accessibility and SEO. Next point is your CSS. It should be linked either by using the link element or the @import method. Both are great and have their advantages. You should be separating style form content. Any behaviour should also be in an external file. Think of it this way, it would be possible with clean code and external CSS to change your whole design by altering a single file (providing you only have one .css file, sometimes it's good to have a few different ones to make it easier to navigate your css at a later date). Also you are putting other presentational elements into the html when they should be in the CSS. Your logo/header is really a visual enhancement of your company name. So you would be better off having: Code:
Code:
Alos you need to use all of the available elements correctly. Think about the meaning of your content. A div element is meant to decide things and is semantically neutral, you've used a few too many here. Remeber with CSS you can style anything, however you want. Paragraph text should be in a element, your heading should be in a or Final note, use a strict doctype. It doesn't matter whether you use HTML or XHTML they are both perfectly valid, what matters is that you use the doctype that helps make sure your code is the best it can be. There are other reasons for using a strict doctype that I won't go into right now. There is more to this web standards malarkey than tableless layouts but it's not so bad when you sus it. It's a lot to take in, I know, but if you start thinking about these things now it'll come together quicker than you might imagine. Your layout is nice you just need a design concept. Try a metaphor, they're used a lot in advertsing and communicate well to users.viewers. As it is it took me a littlw hile to work out what you did and that isn't ideal. If you only achieve one thing, make sure a user knows what you do withing a few seconds. Tag lines can help but a stronger brand would be more useful (oop, I said I wouldn't talk about the design). Apologies for the long post, I'm new around here and here I am taking up precious page space. Pete. :) |
|
|||
|
Under your portfolio the text is off to the right and is unreadable. If you fix the errors and double check all of your links, etc. for broken links (there are a few in the portfolio whre the image won't dispaly) you should be good.
|
![]() |
|
|
| Thread Tools | |
| Display Modes | |
|
|
Similar Threads
|
||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| Wanna translate a website? | Rickman | General Web Design Forum | 3 | 17-03-2008 03:56 PM |
| wanna learn how to code. Help? | Shady | Graphic Design and Web Design Help | 10 | 10-02-2008 05:52 PM |
| All times are GMT. The time now is 03:27 AM. |